jackjlli commented on a change in pull request #4934: Clean up
BitmapInvertedIndexReader
URL: https://github.com/apache/incubator-pinot/pull/4934#discussion_r359069076
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/BitmapInvertedIndexReader.java
##########
@@ -95,32 +90,32 @@ private synchronized ImmutableRoaringBitmap
buildRoaringBitmapForIndex(final int
final int bufferLength = nextOffset - currentOffset;
// Slice the buffer appropriately for Roaring Bitmap
- ByteBuffer bb = buffer.toDirectByteBuffer(currentOffset, bufferLength);
+ ByteBuffer bb = _buffer.toDirectByteBuffer(currentOffset, bufferLength);
ImmutableRoaringBitmap immutableRoaringBitmap = null;
try {
immutableRoaringBitmap = new ImmutableRoaringBitmap(bb);
} catch (Exception e) {
LOGGER.error(
- "Error creating immutableRoaringBitmap for dictionary id:{}
currentOffset:{} bufferLength:{} slice position{} limit:{} file:{}",
- index, currentOffset, bufferLength, bb.position(), bb.limit(),
file.getAbsolutePath());
+ "Error creating immutableRoaringBitmap for dictionary id:{}
currentOffset:{} bufferLength:{} slice position{} limit:{}",
+ index, currentOffset, bufferLength, bb.position(), bb.limit());
}
return immutableRoaringBitmap;
}
private int getOffset(final int index) {
- return buffer.getInt(index * Integer.BYTES);
+ return _buffer.getInt(index * Integer.BYTES);
}
private void load(PinotDataBuffer indexDataBuffer)
throws IOException {
- final int lastOffset = indexDataBuffer.getInt(numberOfBitmaps *
Integer.BYTES);
+ final int lastOffset = indexDataBuffer.getInt(_numberOfBitmaps *
Integer.BYTES);
assert lastOffset == indexDataBuffer.size();
- this.buffer = indexDataBuffer;
+ this._buffer = indexDataBuffer;
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
