mayankshriv commented on a change in pull request #4929: Fix the issue of
server not registering state model factory before connecting the Helix manager
URL: https://github.com/apache/incubator-pinot/pull/4929#discussion_r359097749
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/ServerInstance.java
##########
@@ -38,36 +45,64 @@
public class ServerInstance {
private static final Logger LOGGER =
LoggerFactory.getLogger(ServerInstance.class);
- private ServerMetrics _serverMetrics;
- private InstanceDataManager _instanceDataManager;
- private QueryExecutor _queryExecutor;
- private QueryScheduler _queryScheduler;
- private QueryServer _queryServer;
- private LongAccumulator _latestQueryTime;
+ private final ServerMetrics _serverMetrics;
+ private final InstanceDataManager _instanceDataManager;
+ private final QueryExecutor _queryExecutor;
+ private final LongAccumulator _latestQueryTime;
+ private final QueryScheduler _queryScheduler;
+ private final QueryServer _queryServer;
private boolean _started = false;
- public void init(ServerConf serverConf, ZkHelixPropertyStore<ZNRecord>
propertyStore)
+ public ServerInstance(ServerConf serverConf, HelixManager helixManager)
throws Exception {
LOGGER.info("Initializing server instance");
- ServerBuilder serverBuilder = new ServerBuilder(serverConf, propertyStore);
- _serverMetrics = serverBuilder.getServerMetrics();
- _instanceDataManager = serverBuilder.buildInstanceDataManager();
- _queryExecutor = serverBuilder.buildQueryExecutor(_instanceDataManager);
+ LOGGER.info("Initializing server metrics");
Review comment:
Nit: int()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
