Jackie-Jiang commented on a change in pull request #4937: changing pinot-avro
dependency scope to test from compile
URL: https://github.com/apache/incubator-pinot/pull/4937#discussion_r359105406
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/CreateSegmentCommand.java
##########
@@ -418,6 +419,12 @@ public void run() {
orcRecordReader.init(new File(localFile),
Schema.fromFile(new File(_schemaFile)), null);
driver.init(config, orcRecordReader);
break;
+ case CSV:
+ RecordReader csvRecordReader = new CSVRecordReader();
+ CSVRecordReaderConfig readerConfig =
JsonUtils.fileToObject(new File(_readerConfigFile),
CSVRecordReaderConfig.class);
Review comment:
Check if `_rederConfigFile` is null before loading it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
