codecov-io edited a comment on issue #4942: Refactor SegmentFetcher into FileFetcher to handle more generic file and embed retry logic URL: https://github.com/apache/incubator-pinot/pull/4942#issuecomment-567700054 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4942?src=pr&el=h1) Report > Merging [#4942](https://codecov.io/gh/apache/incubator-pinot/pull/4942?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/0826de532519f0076ad4c98ba865c22bf6a8b90d?src=pr&el=desc) will **increase** coverage by `0.11%`. > The diff coverage is `62.83%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4942?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4942 +/- ## ============================================ + Coverage 56.33% 56.44% +0.11% Complexity 16 16 ============================================ Files 1177 1176 -1 Lines 63017 62986 -31 Branches 9245 9249 +4 ============================================ + Hits 35498 35553 +55 + Misses 24882 24791 -91 - Partials 2637 2642 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4942?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../java/org/apache/pinot/spi/filesystem/PinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/4942/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZmlsZXN5c3RlbS9QaW5vdEZTLmphdmE=) | `71.42% <ø> (+4.76%)` | `0 <0> (ø)` | :arrow_down: | | [...ecutor/BaseMultipleSegmentsConversionExecutor.java](https://codecov.io/gh/apache/incubator-pinot/pull/4942/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhlY3V0b3IvQmFzZU11bHRpcGxlU2VnbWVudHNDb252ZXJzaW9uRXhlY3V0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../executor/BaseSingleSegmentConversionExecutor.java](https://codecov.io/gh/apache/incubator-pinot/pull/4942/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhlY3V0b3IvQmFzZVNpbmdsZVNlZ21lbnRDb252ZXJzaW9uRXhlY3V0b3IuamF2YQ==) | `4.16% <0%> (+0.16%)` | `0 <0> (ø)` | :arrow_down: | | [...in/java/org/apache/pinot/minion/MinionStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4942/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vTWluaW9uU3RhcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ata/manager/realtime/RealtimeTableDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4942/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVUYWJsZURhdGFNYW5hZ2VyLmphdmE=) | `44.61% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...er/api/resources/LLCSegmentCompletionHandlers.java](https://codecov.io/gh/apache/incubator-pinot/pull/4942/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL0xMQ1NlZ21lbnRDb21wbGV0aW9uSGFuZGxlcnMuamF2YQ==) | `61.8% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../server/starter/helix/SegmentFetcherAndLoader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4942/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9TZWdtZW50RmV0Y2hlckFuZExvYWRlci5qYXZh) | `64.07% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...org/apache/pinot/controller/ControllerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4942/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9Db250cm9sbGVyU3RhcnRlci5qYXZh) | `70.4% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...not/common/utils/filefetcher/LocalFileFetcher.java](https://codecov.io/gh/apache/incubator-pinot/pull/4942/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvZmlsZWZldGNoZXIvTG9jYWxGaWxlRmV0Y2hlci5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...rg/apache/pinot/spi/filesystem/PinotFSFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4942/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZmlsZXN5c3RlbS9QaW5vdEZTRmFjdG9yeS5qYXZh) | `58.82% <36.36%> (-6.05%)` | `0 <0> (ø)` | | | ... and [36 more](https://codecov.io/gh/apache/incubator-pinot/pull/4942/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4942?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4942?src=pr&el=footer). Last update [0826de5...ee53243](https://codecov.io/gh/apache/incubator-pinot/pull/4942?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
