kishoreg commented on a change in pull request #4967: Refactor
pinot-batch-ingestion job specs to pinot-spi
URL: https://github.com/apache/incubator-pinot/pull/4967#discussion_r364528425
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/spec/Constants.java
##########
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.pinot.ingestion.common;
+package org.apache.pinot.spi.ingestion.spec;
public class Constants {
Review comment:
is there any other place we can move this to? having a class for just one
constant does not look right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
