chenboat commented on issue #4914: [POC] By-passing deep-store requirement for Realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4914#issuecomment-572348499 > Can you add some more details in your design doc? Specifically: > > 1. The algorithm on the server side during commit. Correct me if I am wrong, but I think you want to commit the metadata, and try uploading the segment to its destnation (whether pinot-fs or controller) in the background. Am I right? Or, is it that you attempt to upload the segment, and only if it fails, you commit the metadata and move on? (I think we should think through this, the latter seems better to me). Updated the section: https://cwiki.apache.org/confluence/display/PINOT/By-passing+deep-store+requirement+for+Realtime+segment+completion#By-passingdeep-storerequirementforRealtimesegmentcompletion-Modifiedsegmentcompletionprotocol > 2. Document the error handling scenario. What happens when the segment upload fails but the commit succeeds ? (the use case for which we are building all this). What happens if another server gets a "download" but the committer has not gotten to ONLINE state yet? I think there are many states here that we need to design correctly. Updated this section (will think more cases but the two cases you mentioned are addressed.) https://cwiki.apache.org/confluence/display/PINOT/By-passing+deep-store+requirement+for+Realtime+segment+completion#By-passingdeep-storerequirementforRealtimesegmentcompletion-Failurehandling
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
