codecov-io edited a comment on issue #4791: Support STRING and BYTES for no dictionary columns in realtime consuming segments URL: https://github.com/apache/incubator-pinot/pull/4791#issuecomment-573269465 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4791?src=pr&el=h1) Report > Merging [#4791](https://codecov.io/gh/apache/incubator-pinot/pull/4791?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/97c7118516ef5ded92b742f8cd89166b3c198b49?src=pr&el=desc) will **increase** coverage by `21.27%`. > The diff coverage is `56.66%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4791?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4791 +/- ## ============================================= + Coverage 36.06% 57.34% +21.27% - Complexity 0 12 +12 ============================================= Files 1174 1174 Lines 62349 62244 -105 Branches 9175 9148 -27 ============================================= + Hits 22487 35694 +13207 + Misses 37851 23879 -13972 - Partials 2011 2671 +660 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4791?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...main/java/org/apache/pinot/spi/data/FieldSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4791/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9GaWVsZFNwZWMuamF2YQ==) | `85.93% <0%> (+85.93%)` | `0 <0> (ø)` | :arrow_down: | | [...re/segment/index/data/source/ColumnDataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4791/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L2RhdGEvc291cmNlL0NvbHVtbkRhdGFTb3VyY2UuamF2YQ==) | `95.74% <100%> (+4.44%)` | `0 <0> (ø)` | :arrow_down: | | [...riter/BaseSingleColumnSingleValueReaderWriter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4791/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby9yZWFkZXJ3cml0ZXIvQmFzZVNpbmdsZUNvbHVtblNpbmdsZVZhbHVlUmVhZGVyV3JpdGVyLmphdmE=) | `29.62% <33.33%> (+9.62%)` | `0 <0> (ø)` | :arrow_down: | | [.../FixedByteSingleColumnSingleValueReaderWriter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4791/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby9yZWFkZXJ3cml0ZXIvaW1wbC9GaXhlZEJ5dGVTaW5nbGVDb2x1bW5TaW5nbGVWYWx1ZVJlYWRlcldyaXRlci5qYXZh) | `98.94% <50%> (+5.39%)` | `0 <0> (ø)` | :arrow_down: | | [.../core/indexsegment/mutable/MutableSegmentImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4791/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvbXV0YWJsZS9NdXRhYmxlU2VnbWVudEltcGwuamF2YQ==) | `81.1% <54.16%> (+16.45%)` | `0 <0> (ø)` | :arrow_down: | | [...pl/VarByteSingleColumnSingleValueReaderWriter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4791/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby9yZWFkZXJ3cml0ZXIvaW1wbC9WYXJCeXRlU2luZ2xlQ29sdW1uU2luZ2xlVmFsdWVSZWFkZXJXcml0ZXIuamF2YQ==) | `61.53% <61.53%> (ø)` | `0 <0> (?)` | | | [...erter/stats/RealtimeNoDictionaryColStatistics.java](https://codecov.io/gh/apache/incubator-pinot/pull/4791/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvc3RhdHMvUmVhbHRpbWVOb0RpY3Rpb25hcnlDb2xTdGF0aXN0aWNzLmphdmE=) | `70% <66.66%> (+6%)` | `0 <0> (ø)` | :arrow_down: | | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4791/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `50% <0%> (-25%)` | `0% <0%> (ø)` | | | [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4791/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `48.78% <0%> (-19.52%)` | `0% <0%> (ø)` | | | [...pinot/broker/api/resources/PinotClientRequest.java](https://codecov.io/gh/apache/incubator-pinot/pull/4791/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYXBpL3Jlc291cmNlcy9QaW5vdENsaWVudFJlcXVlc3QuamF2YQ==) | `31.91% <0%> (-10.95%)` | `0% <0%> (ø)` | | | ... and [639 more](https://codecov.io/gh/apache/incubator-pinot/pull/4791/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4791?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4791?src=pr&el=footer). Last update [97c7118...33f780f](https://codecov.io/gh/apache/incubator-pinot/pull/4791?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
