siddharthteotia opened a new pull request #4980: QueryServer need not be a Runnable URL: https://github.com/apache/incubator-pinot/pull/4980 QueryServer (the Netty server on pinot-server to accept incoming connections from broker) is wrapped around a Runnable and the thread is just blocked waiting for the channel's close future to be completed -- By channel, I am referring to the one created during bootstrapping after bind() is completed to the local port and the server is ready to accept incoming connections (and create child channels). A thread is not really needed since the shutdown method (called during ServerInstance shutdown) will anyway close the channel. Looks like the purpose of wrapping it around a thread was to prevent the caller who is starting the QueryServer from blocking since the latter would do channel.closeFuture().sync().
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
