codecov-io commented on issue #4985: Enable leadControllerResource's IS after the first live instance shows up URL: https://github.com/apache/incubator-pinot/pull/4985#issuecomment-574466955 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4985?src=pr&el=h1) Report > Merging [#4985](https://codecov.io/gh/apache/incubator-pinot/pull/4985?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/5919af174dd006117ee497e1c6d692922dba9d70?src=pr&el=desc) will **increase** coverage by `15.38%`. > The diff coverage is `62.5%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4985?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4985 +/- ## ============================================= + Coverage 36.43% 51.81% +15.38% - Complexity 0 12 +12 ============================================= Files 1174 1176 +2 Lines 62253 62400 +147 Branches 9148 9168 +20 ============================================= + Hits 22682 32333 +9651 + Misses 37536 27591 -9945 - Partials 2035 2476 +441 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4985?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ot/controller/helix/core/util/HelixSetupUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4985/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3V0aWwvSGVsaXhTZXR1cFV0aWxzLmphdmE=) | `88.88% <100%> (+0.13%)` | `0 <0> (ø)` | :arrow_down: | | [...org/apache/pinot/controller/ControllerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4985/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9Db250cm9sbGVyU3RhcnRlci5qYXZh) | `68.62% <58.33%> (+2.18%)` | `0 <0> (ø)` | :arrow_down: | | [...ntroller/helix/core/PinotHelixResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4985/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1Bpbm90SGVsaXhSZXNvdXJjZU1hbmFnZXIuamF2YQ==) | `59.09% <66.66%> (+25.79%)` | `0 <0> (ø)` | :arrow_down: | | [...starter/helix/DefaultHelixStarterServerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4985/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9EZWZhdWx0SGVsaXhTdGFydGVyU2VydmVyQ29uZmlnLmphdmE=) | `0% <0%> (-96.16%)` | `0% <0%> (ø)` | | | [...converter/stats/RealtimeSegmentStatsContainer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4985/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvc3RhdHMvUmVhbHRpbWVTZWdtZW50U3RhdHNDb250YWluZXIuamF2YQ==) | `0% <0%> (-94.45%)` | `0% <0%> (ø)` | | | [...rg/apache/pinot/tools/utils/KafkaStarterUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4985/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3V0aWxzL0thZmthU3RhcnRlclV0aWxzLmphdmE=) | `0% <0%> (-93.19%)` | `0% <0%> (ø)` | | | [.../starter/helix/HelixInstanceDataManagerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4985/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeEluc3RhbmNlRGF0YU1hbmFnZXJDb25maWcuamF2YQ==) | `0% <0%> (-92.31%)` | `0% <0%> (ø)` | | | [...ot/tools/query/comparison/SegmentInfoProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4985/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vU2VnbWVudEluZm9Qcm92aWRlci5qYXZh) | `0% <0%> (-88.68%)` | `0% <0%> (ø)` | | | [.../transform/function/MapValueTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4985/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vTWFwVmFsdWVUcmFuc2Zvcm1GdW5jdGlvbi5qYXZh) | `0% <0%> (-85.3%)` | `0% <0%> (ø)` | | | [...rg/apache/pinot/server/starter/ServerInstance.java](https://codecov.io/gh/apache/incubator-pinot/pull/4985/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9TZXJ2ZXJJbnN0YW5jZS5qYXZh) | `1.49% <0%> (-83.59%)` | `0% <0%> (ø)` | | | ... and [709 more](https://codecov.io/gh/apache/incubator-pinot/pull/4985/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4985?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4985?src=pr&el=footer). Last update [5919af1...4f3bb58](https://codecov.io/gh/apache/incubator-pinot/pull/4985?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
