vincentchenjl commented on a change in pull request #4984: [TE] Fix
over-scheduling tasks in data availability scheduler
URL: https://github.com/apache/incubator-pinot/pull/4984#discussion_r367078096
##########
File path:
thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/anomaly/detection/trigger/DataAvailabilityTaskSchedulerTest.java
##########
@@ -110,8 +110,8 @@ public void testCreateMultipleTasks() {
long detection2 = createDetection(2, metrics1, oneDayAgo, 0);
List<Long> singleMetric = Collections.singletonList(metricId2);
long detection3 = createDetection(3, singleMetric, oneDayAgo, 0);
- createDataset(1, TEST_TIME);
- createDataset(2, TEST_TIME);
+ createDataset(1, TEST_TIME, TEST_TIME);
Review comment:
Yes, they are always different in production. I simplify it in test case to
make them the same, since we never compare those two timestamps anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
