kishoreg commented on a change in pull request #4973: Add Avro Schema Registry 
Message Decoder
URL: https://github.com/apache/incubator-pinot/pull/4973#discussion_r367168284
 
 

 ##########
 File path: 
pinot-plugins/pinot-input-format/pinot-confluent-avro/src/main/java/org/apache/pinot/plugin/inputformat/avro/confluent/KafkaConfluentSchemaRegistryAvroMessageDecoder.java
 ##########
 @@ -0,0 +1,66 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.plugin.inputformat.avro.confluent;
+
+import io.confluent.kafka.schemaregistry.client.CachedSchemaRegistryClient;
+import io.confluent.kafka.schemaregistry.client.SchemaRegistryClient;
+import io.confluent.kafka.serializers.KafkaAvroDeserializer;
+import org.apache.avro.generic.GenericData.Record;
+import org.apache.pinot.plugin.inputformat.avro.AvroRecordExtractor;
+import org.apache.pinot.spi.data.Schema;
+import org.apache.pinot.spi.data.readers.GenericRow;
+import org.apache.pinot.spi.data.readers.RecordExtractor;
+import org.apache.pinot.spi.plugin.PluginManager;
+import org.apache.pinot.spi.stream.StreamMessageDecoder;
+
+import java.util.Arrays;
+import java.util.Map;
+
+import static com.google.common.base.Preconditions.checkState;
+import static java.util.Objects.requireNonNull;
+
+public class KafkaConfluentSchemaRegistryAvroMessageDecoder implements 
StreamMessageDecoder<byte[]> {
+    private static final String SCHEMA_REGISTRY_REST_URL = 
"schema.registry.rest.url";
+    private KafkaAvroDeserializer deserializer;
+    private RecordExtractor<Record> avroRecordConvetrer;
+    private String topicName;
+    private Schema pinotSchema;
+
+    @Override
+    public void init(Map<String, String> props, Schema indexingSchema, String 
topicName) throws Exception {
+        checkState(props.containsKey(SCHEMA_REGISTRY_REST_URL), "Missing 
required property '%s'", SCHEMA_REGISTRY_REST_URL);
+        String schemaRegistryUrl = props.get(SCHEMA_REGISTRY_REST_URL);
+        pinotSchema = requireNonNull(indexingSchema, "indexingSchema is null");
+        SchemaRegistryClient schemaRegistryClient = new 
CachedSchemaRegistryClient(schemaRegistryUrl, 1000);
+        deserializer = new KafkaAvroDeserializer(schemaRegistryClient);
+        this.topicName = requireNonNull(topicName, "topicName is null");
+        this.avroRecordConvetrer = 
PluginManager.get().createInstance(AvroRecordExtractor.class.getName());
 
 Review comment:
   Its probably ok to duplicate the AvroRecordExtractor. Plugin depending on 
another plugin will probably make things harder. For e.g. Avro versions might 
be different between pinot-avro and pinot-confluent-avro

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to