mcvsubbu commented on a change in pull request #4954: Support schema evolution
for consuming segments
URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r368325394
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -252,6 +258,16 @@ public long getMaxTime() {
return _maxTime;
}
+ public void addExtraColumns(Schema newSchema,
+ Map<String, BaseDefaultColumnHandler.DefaultColumnAction>
defaultColumnActionMap) {
Review comment:
I think we should remove the DefaultColumnAction here. We know that there is
only one thing we can do -- add columns with a default value. The only argument
needed here is newSchema
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
