Jackie-Jiang commented on a change in pull request #4989: Add documentation to fields of important query execution stats. URL: https://github.com/apache/incubator-pinot/pull/4989#discussion_r369178479
########## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/SizeBasedDocIdSet.java ########## @@ -21,7 +21,7 @@ import org.apache.pinot.core.common.BlockDocIdIterator; import org.apache.pinot.core.operator.dociditerators.SizeBasedDocIdIterator; - +// TODO: javadoc this class. Review comment: Can you change the TODO to: `Rename the class to MatchAllDocIdSet` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
