siddharthteotia commented on a change in pull request #5006: Add FieldConfig.
URL: https://github.com/apache/incubator-pinot/pull/5006#discussion_r369984530
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java
##########
@@ -82,7 +88,8 @@ public TableConfig() {
private TableConfig(String tableName, TableType tableType,
SegmentsValidationAndRetentionConfig validationConfig,
TenantConfig tenantConfig, IndexingConfig indexingConfig,
TableCustomConfig customConfig,
@Nullable QuotaConfig quotaConfig, @Nullable TableTaskConfig taskConfig,
@Nullable RoutingConfig routingConfig,
- @Nullable Map<InstancePartitionsType, InstanceAssignmentConfig>
instanceAssignmentConfigMap) {
+ @Nullable Map<InstancePartitionsType, InstanceAssignmentConfig>
instanceAssignmentConfigMap,
+ @Null List<FieldConfig> fieldConfigList) {
Review comment:
Yes that was a typo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
