Jackie-Jiang commented on a change in pull request #4989: Add documentation to
fields of important query execution stats.
URL: https://github.com/apache/incubator-pinot/pull/4989#discussion_r370791947
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/ExecutionStatistics.java
##########
@@ -22,8 +22,13 @@
* The <code>ExecutionStatistics</code> class contains the operator statistics
during execution time.
*/
public class ExecutionStatistics {
+ // The number of documents scanned post filtering.
private long _numDocsScanned;
+ // The number of entries (single value entry contains 1 entry, multi-value
entry may contain multiple entries) in the
+ // filtering phase of the query execution: could be larger than the total
scanned doc num because of multiple
+ // filtering predicates and multi-value entry.
Review comment:
Oh sorry my bad, you are right. The semantic for this value changed with
#4455 and I totally forgot about it...
So right now the entry has different meaning in `_numEntriesScannedInFilter`
(each MV value contains multiple entries) and `_numEntriesScannedInFilter`
(both SV and MV value are counted as one entry).
Can you please add a TODO to make entry semantic the same in
`_numEntriesScannedInFilter` and `_numEntriesScannedInFilter`? Currently it is
very misleading.
I think it might be better to add a new stats `_numValuesScannedInFilter` to
replace the current `_numEntriesScannedInFilter`, but it is out of the scope of
this pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
