mcvsubbu commented on a change in pull request #4933: Fix benchmark client
URL: https://github.com/apache/incubator-pinot/pull/4933#discussion_r371042592
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -259,7 +259,7 @@ public HelixAdmin getHelixAdmin() {
private void addInstanceGroupTagIfNeeded() {
InstanceConfig instanceConfig = getHelixInstanceConfig(_instanceId);
assert instanceConfig != null;
- if (!instanceConfig.containsTag(Helix.CONTROLLER_INSTANCE)) {
+ if (instanceConfig != null &&
!instanceConfig.containsTag(Helix.CONTROLLER_INSTANCE)) {
Review comment:
Yes, I finally got around to it, and my sincere apologies for the delay.
Please remove the assert statement before the line. Instead, add a comment
that instanceConfig can be null when connecting as a participant while running
from PerfBenchmarkRunner.
Also, another minor fix is needed.
Please change line 241 in PerfBenchmarkDriver to set the correct instance
name for the server. It should be
`serverConfiguration.setProperty(CommonConstants.Server.CONFIG_OF_INSTANCE_ID,
_serverInstanceName);`
Thanks once again for the fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
