kishoreg commented on a change in pull request #5018: Support arithmetic
operators like '+','-','*','/'
URL: https://github.com/apache/incubator-pinot/pull/5018#discussion_r371260811
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunctionFactory.java
##########
@@ -49,6 +50,10 @@ private TransformFunctionFactory() {
put(SubtractionTransformFunction.FUNCTION_NAME.toLowerCase(),
SubtractionTransformFunction.class);
put(MultiplicationTransformFunction.FUNCTION_NAME.toLowerCase(),
MultiplicationTransformFunction.class);
put(DivisionTransformFunction.FUNCTION_NAME.toLowerCase(),
DivisionTransformFunction.class);
+ put(SqlKind.PLUS.name().toLowerCase(),
AdditionTransformFunction.class);
Review comment:
It’s probably better to change the function name in calcite sql parser to
match Pinot functions. This will restrict calcite classes to parsing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
