siddharthteotia commented on a change in pull request #5013: For RANGE
predicate queries touching offline segments, use sorted inverted index if the
column is sorted
URL: https://github.com/apache/incubator-pinot/pull/5013#discussion_r371404432
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/FilterOperatorUtils.java
##########
@@ -56,16 +57,23 @@ public static BaseFilterOperator
getLeafFilterOperator(PredicateEvaluator predic
// Use inverted index if the predicate type is not RANGE or REGEXP_LIKE
for efficiency
DataSourceMetadata dataSourceMetadata = dataSource.getDataSourceMetadata();
Predicate.Type predicateType = predicateEvaluator.getPredicateType();
- if (dataSourceMetadata.hasInvertedIndex() && (predicateType !=
Predicate.Type.RANGE) && (predicateType
- != Predicate.Type.REGEXP_LIKE)) {
- if (dataSourceMetadata.isSorted()) {
+ if (dataSourceMetadata.hasInvertedIndex() && (predicateType !=
Predicate.Type.REGEXP_LIKE)) {
+ if (shouldUseSortedInvertedIndexOperator(dataSource, predicateType)) {
Review comment:
Discussed offline.
dataSourceMetadata.isSorted() is enough since we
dataSourceMetadata.hasInvertedIndex() will always be false for realtime
segments so we don't need an enhanced check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
