siddharthteotia commented on a change in pull request #5016: Support alias 
replacement in PinotQuery
URL: https://github.com/apache/incubator-pinot/pull/5016#discussion_r371406458
 
 

 ##########
 File path: 
pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java
 ##########
 @@ -887,4 +887,66 @@ public void testQueryValidation() {
       Assert.assertTrue(e.getMessage().contains("is not allowed in GROUP BY 
clause."));
     }
   }
+
+  @Test
+  public void testAliasQuery() {
 
 Review comment:
   For completeness, can we also add a test case where we have a mix of 
expressions and for some we use AS, and for others we don't.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to