npawar commented on a change in pull request #5019: Make output schema to match
selection list for aggregation groupbys
URL: https://github.com/apache/incubator-pinot/pull/5019#discussion_r371439798
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java
##########
@@ -194,14 +210,104 @@ private void
setSQLGroupByInResultTable(BrokerResponseNative brokerResponseNativ
values[index] =
_aggregationFunctions[aggNum++].extractFinalResult(values[index]);
index++;
}
- rows.add(values);
+ if (_sqlSelectionList != null) {
+ Object[] finalValues = new Object[_sqlSelectionList.size()];
+ for (int i = 0; i < finalSchemaMapIdx.length; i++) {
+ if (finalSchemaMapIdx[i] == -1) {
Review comment:
should this ever happen? the validation during parsing should prevent this
right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
