kishoreg commented on a change in pull request #5023: Make pinot-client to
query sql endpoint by default
URL: https://github.com/apache/incubator-pinot/pull/5023#discussion_r376741070
##########
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java
##########
@@ -59,14 +62,25 @@ public PreparedStatement prepareStatement(String
statement) {
}
/**
- * Executes a PQL statement.
+ * Executes a SQL statement.
* @param statement The statement to execute
* @return The result of the query
* @throws PinotClientException If an exception occurs while processing the
query
*/
public ResultSetGroup execute(String statement)
throws PinotClientException {
- return execute(null, new Request("pql", statement));
+ return execute(null, new Request(SQL, statement));
Review comment:
better to leave the existing client as it is and add a new client api to
query the new end point. We dont want the existing usage to break.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
