siddharthteotia edited a comment on issue #4993: Support Text column type in 
Pinot (both offline and realtime)
URL: https://github.com/apache/incubator-pinot/pull/4993#issuecomment-585427783
 
 
   @mcvsubbu , I have addressed the review comments:
   
   Latest changes:
   
   - Move the realtime state handler to a separate class 
RealtimeLuceneIndexRefreshState. This manages the global queue.
   - The background task is started only if we have a TEXT index column.
   - Other review comments
   - Rebased on my previous FieldConfig change. Text index creation info for a 
column is now specified as part of FieldConfig.
   
   **Major TODO:**
   
   Handle segment reload. Once this PR goes in, I will come up with a follow-up 
PR immediately to address that. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to