siddharthteotia commented on a change in pull request #4993: Support Text
column type in Pinot (both offline and realtime)
URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r379300512
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/InvertedIndexReader.java
##########
@@ -19,12 +19,20 @@
package org.apache.pinot.core.segment.index.readers;
import java.io.Closeable;
+import org.apache.pinot.core.common.Predicate;
public interface InvertedIndexReader<T> extends Closeable {
/**
* Get the document ids for the given dictionary id.
+ * @param dictId dictionary ID
*/
T getDocIds(int dictId);
+
+ /**
+ * Get the document ids after evaluating the given predicate
+ * @param predicate predicate
+ */
+ T getDocIds(Predicate predicate);
Review comment:
As discussed offline, this interface might help in extending it in the
future when we implement native text index and add support for complex objects.
However, I have changed the API to getDocIds(Object value) instead of
getDocIds(Predicate predicate). This makes it intuitive to use our inverted
index readers for both dictionary ID based lookup and raw value (or search
query) based lookup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
