siddharthteotia opened a new pull request #5072: Use getResourceAsStream to load test resource file packaged inside test jar URL: https://github.com/apache/incubator-pinot/pull/5072 Text search integration test which is in pinot-integrations tests module uses test data resources from pinot-core. pinot-core test jar is available to pinot-integration-tests module via pom dependency. However, our internal release builds failed since the test file is actually present in pinot-core-VERSION-SNAPSHOT-tests.jar. getClass().getClassLoader().getResource() works only if the resource is a physical file object. For resources available inside jars, the path as an "!" to denote that resource is actually inside a jar. getResourceAsStream() should be used in such cases. I am not quite sure why travis succeeds and our internal build fails. I will look into it. Meanwhile, this fix should unblock our internal builds. We had seen this earlier as well when a integration test in pinot-hadoop module failed to read the resource inside a jar -- that is currently disabled.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
