codecov-io commented on issue #5075: Fix bug in DISTINCT for queries that return empty response URL: https://github.com/apache/incubator-pinot/pull/5075#issuecomment-586806853 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5075?src=pr&el=h1) Report > Merging [#5075](https://codecov.io/gh/apache/incubator-pinot/pull/5075?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/4be7490eeef635157fc62d8750a5dde6e5a5db5e?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5075?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #5075 +/- ## ============================================ + Coverage 58.5% 58.51% +0.01% Complexity 12 12 ============================================ Files 1208 1208 Lines 64512 64517 +5 Branches 9482 9482 ============================================ + Hits 37741 37753 +12 + Misses 24026 24010 -16 - Partials 2745 2754 +9 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5075?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...regation/function/DistinctAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5075/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9EaXN0aW5jdEFnZ3JlZ2F0aW9uRnVuY3Rpb24uamF2YQ==) | `78.46% <100%> (+1.79%)` | `0 <0> (ø)` | :arrow_down: | | [...l/invertedindex/RealtimeLuceneTextIndexReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/5075/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2ludmVydGVkaW5kZXgvUmVhbHRpbWVMdWNlbmVUZXh0SW5kZXhSZWFkZXIuamF2YQ==) | `55.73% <0%> (-9.84%)` | `0% <0%> (ø)` | | | [...lix/core/realtime/PinotRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5075/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1Bpbm90UmVhbHRpbWVTZWdtZW50TWFuYWdlci5qYXZh) | `73.84% <0%> (-7.7%)` | `0% <0%> (ø)` | | | [...org/apache/pinot/broker/queryquota/HitCounter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5075/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IaXRDb3VudGVyLmphdmE=) | `92.3% <0%> (-7.7%)` | `0% <0%> (ø)` | | | [...ng/builder/DefaultRealtimeRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/5075/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9idWlsZGVyL0RlZmF1bHRSZWFsdGltZVJvdXRpbmdUYWJsZUJ1aWxkZXIuamF2YQ==) | `61.9% <0%> (-4.77%)` | `0% <0%> (ø)` | | | [...roker/requesthandler/BaseBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/5075/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQmFzZUJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `79.6% <0%> (-3.4%)` | `0% <0%> (ø)` | | | [...org/apache/pinot/client/DynamicBrokerSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5075/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0R5bmFtaWNCcm9rZXJTZWxlY3Rvci5qYXZh) | `69.69% <0%> (-3.04%)` | `0% <0%> (ø)` | | | [.../main/java/org/apache/pinot/client/Connection.java](https://codecov.io/gh/apache/incubator-pinot/pull/5075/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Nvbm5lY3Rpb24uamF2YQ==) | `47.61% <0%> (-2.39%)` | `0% <0%> (ø)` | | | [...n/src/main/java/org/apache/pinot/common/Utils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5075/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vVXRpbHMuamF2YQ==) | `57.44% <0%> (-2.13%)` | `0% <0%> (ø)` | | | [...l/FixedByteSingleColumnMultiValueReaderWriter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5075/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby9yZWFkZXJ3cml0ZXIvaW1wbC9GaXhlZEJ5dGVTaW5nbGVDb2x1bW5NdWx0aVZhbHVlUmVhZGVyV3JpdGVyLmphdmE=) | `68.91% <0%> (-2.08%)` | `0% <0%> (ø)` | | | ... and [21 more](https://codecov.io/gh/apache/incubator-pinot/pull/5075/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5075?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5075?src=pr&el=footer). Last update [4be7490...f0306ed](https://codecov.io/gh/apache/incubator-pinot/pull/5075?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
