mcvsubbu commented on a change in pull request #5074: Support segment reload
for text index
URL: https://github.com/apache/incubator-pinot/pull/5074#discussion_r381546904
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/defaultcolumn/V3DefaultColumnHandler.java
##########
@@ -61,21 +63,27 @@ protected void updateDefaultColumn(String column,
DefaultColumnAction action)
"Default value indices for column: " + column + " cannot be removed
for V3 format segment.");
}
- // Create new dictionary and forward index, and update column metadata
- createColumnV1Indices(column);
-
- // Write index to V3 format.
FieldSpec fieldSpec = _schema.getFieldSpecFor(column);
Preconditions.checkNotNull(fieldSpec);
boolean isSingleValue = fieldSpec.isSingleValueField();
- File dictionaryFile = new File(_indexDir, column +
V1Constants.Dict.FILE_EXTENSION);
- File forwardIndexFile;
- if (isSingleValue) {
- forwardIndexFile = new File(_indexDir, column +
V1Constants.Indexes.SORTED_SV_FORWARD_INDEX_FILE_EXTENSION);
+
+ Set<String> textIndexColumns = indexLoadingConfig.getTextIndexColumns();
Review comment:
Provided there are no assumptions anywhere that (text index == raw forward
index).
To start with, it is ok to keep things consistent, and relax the constraints
as we move forward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
