This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 83215f0 Fix a NullPointerException that can occur if an Exception is
raised when reading a JSON Record file. (#5128)
83215f0 is described below
commit 83215f025891979b3641af25b11a5f872cd3a3fa
Author: quietgopher <[email protected]>
AuthorDate: Sat Mar 7 21:32:49 2020 -0800
Fix a NullPointerException that can occur if an Exception is raised when
reading a JSON Record file. (#5128)
_iterator will be null if an Exception is raised. _iterator.close() causes
an NPE.
---
.../org/apache/pinot/plugin/inputformat/json/JSONRecordReader.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
a/pinot-plugins/pinot-input-format/pinot-json/src/main/java/org/apache/pinot/plugin/inputformat/json/JSONRecordReader.java
b/pinot-plugins/pinot-input-format/pinot-json/src/main/java/org/apache/pinot/plugin/inputformat/json/JSONRecordReader.java
index dc75cad..60571af 100644
---
a/pinot-plugins/pinot-input-format/pinot-json/src/main/java/org/apache/pinot/plugin/inputformat/json/JSONRecordReader.java
+++
b/pinot-plugins/pinot-input-format/pinot-json/src/main/java/org/apache/pinot/plugin/inputformat/json/JSONRecordReader.java
@@ -53,7 +53,9 @@ public class JSONRecordReader implements RecordReader {
_iterator = JsonUtils.DEFAULT_READER.forType(new
TypeReference<Map<String, Object>>() {
}).readValues(_dataFile);
} catch (Exception e) {
- _iterator.close();
+ if (_iterator != null) {
+ _iterator.close();
+ }
throw e;
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
