Jackie-Jiang commented on a change in pull request #5144: Refactor value based
segment pruner to work on DataSource instead of ColumnMetadata
URL: https://github.com/apache/incubator-pinot/pull/5144#discussion_r393259178
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/pruner/ColumnValueSegmentPruner.java
##########
@@ -19,184 +19,224 @@
package org.apache.pinot.core.query.pruner;
import java.util.HashMap;
-import java.util.List;
import java.util.Map;
-import javax.annotation.Nonnull;
+import java.util.Set;
import org.apache.commons.configuration.Configuration;
-import org.apache.pinot.spi.data.FieldSpec;
-import org.apache.pinot.common.request.FilterOperator;
+import org.apache.pinot.common.request.transform.TransformExpressionTree;
import org.apache.pinot.common.utils.request.FilterQueryTree;
+import org.apache.pinot.core.common.DataSource;
+import org.apache.pinot.core.common.DataSourceMetadata;
import org.apache.pinot.core.common.predicate.RangePredicate;
+import org.apache.pinot.core.data.partition.PartitionFunction;
import org.apache.pinot.core.indexsegment.IndexSegment;
+import org.apache.pinot.core.query.exception.BadQueryRequestException;
import org.apache.pinot.core.query.request.ServerQueryRequest;
-import org.apache.pinot.core.segment.index.ColumnMetadata;
-import org.apache.pinot.core.segment.index.SegmentMetadataImpl;
import org.apache.pinot.core.segment.index.readers.BloomFilterReader;
+import org.apache.pinot.spi.data.FieldSpec.DataType;
+import org.apache.pinot.spi.utils.BytesUtils;
/**
- * An implementation of SegmentPruner.
- * <p>Pruner will prune segment based on the column value inside the filter.
+ * The {@code ColumnValueSegmentPruner} is the segment pruner that prunes
segments based on the value inside the filter.
Review comment:
Updated the doc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
