jihaozh commented on a change in pull request #5152: [TE][subscription] update
subscription watermarks to use anomaly create time instead of end time
URL: https://github.com/apache/incubator-pinot/pull/5152#discussion_r393898983
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/validators/SubscriptionConfigValidator.java
##########
@@ -90,10 +90,6 @@ public void validateConfig(DetectionAlertConfigDTO
alertConfig) throws IllegalAr
*/
@Override
public void validateYaml(Map<String, Object> config) throws
IllegalArgumentException {
- // Make sure recipients are configured at the right place
- Preconditions.checkArgument(!config.containsKey(PROP_RECIPIENTS),
Review comment:
Are we removing this? Seems unrelated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
