xiaohui-sun commented on a change in pull request #5165: [TE] Fix issue of
displaying latests data in the speed-up case
URL: https://github.com/apache/incubator-pinot/pull/5165#discussion_r395719318
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/wrapper/AnomalyDetectorWrapper.java
##########
@@ -290,6 +291,16 @@ long getLastTimeStamp() {
DateTime startTime = endTime.minus(windowSizePeriod);
monitoringWindows.add(new Interval(startTime, endTime));
}
+ if (isSpeedUp) {
Review comment:
Sorry I didn't notice that.
Since here is the place all the windows are generated. I don't see a reason
why you need to modify existing windows instead of adding the check when
generating the windows.
Can we just change L289 from
DateTime endTime = monitoringEndTime.minus(windowDelayPeriod);
To:
DateTime windowEndTime =
Math.min(monitoringEndTime.minus(windowDelayPeriod), endTime)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
