jackjlli commented on a change in pull request #5174: Add
EarlyTerminationException to prevent logging too many invalid error messages
URL: https://github.com/apache/incubator-pinot/pull/5174#discussion_r396727816
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/CombineOperator.java
##########
@@ -117,6 +118,8 @@ public void runJob() {
}
}
blockingQueue.offer(mergedBlock);
+ } catch (EarlyTerminationException e) {
Review comment:
Could you add some unit tests/ integration tests for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
