kishoreg commented on a change in pull request #5175: add pinot upsert features
to pinot common
URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r396914763
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java
##########
@@ -631,4 +751,50 @@ public int hashCode() {
result = EqualityUtils.hashCodeOf(result, _dateTimeFieldSpecs);
return result;
}
+
+ public boolean isVirtualColumn(String columnName) {
+ return columnName.startsWith("$") ||
(getFieldSpecFor(columnName).getVirtualColumnProvider() != null
+ && !getFieldSpecFor(columnName).getVirtualColumnProvider().isEmpty());
+ }
+
+
+ @JsonIgnore
+ public static byte[] getByteArrayFromField(Object value, DimensionFieldSpec
fieldSpec) {
Review comment:
why is this needed? it will be great if we can avoid static methods in
config objects. We can probably move this SchemaUtil
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
