mcvsubbu commented on a change in pull request #4914: [POC] By-passing
deep-store requirement for Realtime segment completion
URL: https://github.com/apache/incubator-pinot/pull/4914#discussion_r403151856
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -197,6 +197,9 @@ public ServerType getServerType() {
public static final String CONFIG_OF_ENABLE_COMMIT_END_WITH_METADATA =
"pinot.server.instance.enable.commitend.metadata";
public static final String CONFIG_OF_REALTIME_OFFHEAP_ALLOCATION =
"pinot.server.instance.realtime.alloc.offheap";
+ public static final String CONFIG_OF_REALTIME_ENABLE_UPLOAD_TO_CONTROLLER
= "pinot.server.instance.enable.upload.segment.to.controller";
Review comment:
We have re-factored the code to have a separate committer class. Please
re-factor it further to allow the code to use any committer class. The
committer class should be configured in table config. You can then add all the
logic on the server side without needing this config
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
