chenboat commented on issue #4914: [POC] By-passing deep-store requirement for Realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4914#issuecomment-610080673 Make sense. I thought you were talking about controller side change. I think the second option (i.e., pluggable committer in config) looks clearer. I will add these to the design doc. Thanks. @mcvsubbu > The config change in step 5 is because we want the segment split-committer to look like this: > > ``` > doCommitStart(); > url = uploadSegmentToDeepStore(); > if (url == null) { // upload failed, or no deep store configured > if (tableConfig.commitEvenIfUploadFailed) { > segmentUrlForCommitEnd = PEER_URL > } else { > throw CommitFailedException > } > } else { > segmentUrilForCommitEnd = url > } > doCommitEnd(); > ``` > > The config is needed in order to decide the action when upload returns null url. > > Another way to do it is to configure a new class in `StreamConfig` section and use that class to bypass deep-store. Them you can leave the main split-committer as is, and build another class that can be configured in. > > Either way, you need a config.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
