Jackie-Jiang commented on a change in pull request #5213: Support order-by on
BYTES column
URL: https://github.com/apache/incubator-pinot/pull/5213#discussion_r405239332
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java
##########
@@ -332,11 +330,14 @@ private IndexedTable getIndexedTable(DataSchema
dataSchema, Collection<DataTable
function = dataTable::getString;
break;
case BYTES:
- // FIXME: support BYTES in DataTable instead of converting to
string
- function = (row, col) ->
BytesUtils.toByteArray(dataTable.getString(row, col));
+ function = dataTable::getBytes;
break;
- default:
+ case OBJECT:
Review comment:
Yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
