Jackie-Jiang commented on a change in pull request #5238: Evaluate schema
transform expressions during ingestion
URL: https://github.com/apache/incubator-pinot/pull/5238#discussion_r407801047
##########
File path:
pinot-plugins/pinot-input-format/pinot-confluent-avro/src/main/java/org/apache/pinot/plugin/inputformat/avro/confluent/KafkaConfluentSchemaRegistryAvroMessageDecoder.java
##########
@@ -44,13 +46,14 @@
private KafkaAvroDeserializer deserializer;
private RecordExtractor<Record> avroRecordConverter;
private String topicName;
- private Schema pinotSchema;
+ private List<String> _sourceFieldNames;
@Override
public void init(Map<String, String> props, Schema indexingSchema, String
topicName) throws Exception {
checkState(props.containsKey(SCHEMA_REGISTRY_REST_URL), "Missing
required property '%s'", SCHEMA_REGISTRY_REST_URL);
String schemaRegistryUrl = props.get(SCHEMA_REGISTRY_REST_URL);
- pinotSchema = requireNonNull(indexingSchema, "indexingSchema is null");
+ requireNonNull(indexingSchema, "indexingSchema is null");
Review comment:
```suggestion
Preconditions.checkState(indexingSchema != null, "Schema must be
provided");
```
Also remove the static import
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
