mcvsubbu commented on a change in pull request #5260: Add access control for
Pinot server segment download api.
URL: https://github.com/apache/incubator-pinot/pull/5260#discussion_r409765830
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java
##########
@@ -153,8 +154,18 @@ public HelixServerStarter(String helixClusterName, String
zkAddress, Configurati
updateInstanceConfigIfNeeded(host, port);
// Start restlet server for admin API endpoint
+ String accessControlFactoryClass =
+ _serverConf.getString(ACCESS_CONTROL_FACTORY_CLASS,
DEFAULT_ACCESS_CONTROL_FACTORY_CLASS);
+ LOGGER.info("Use class: {} as the AccessControlFactory",
accessControlFactoryClass);
+ final AccessControlFactory accessControlFactory;
+ try {
+ accessControlFactory = (AccessControlFactory)
Class.forName(accessControlFactoryClass).newInstance();
Review comment:
Please use `PluginManager.createInstance()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
