Jackie-Jiang commented on a change in pull request #5256: Derive num docs per
chunk from max column value length for varbyte raw index creator
URL: https://github.com/apache/incubator-pinot/pull/5256#discussion_r409782074
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
##########
@@ -338,7 +339,7 @@ void createV1ForwardIndexForTextIndex(String column,
IndexLoadingConfig indexLoa
int totalDocs = _segmentMetadata.getTotalDocs();
Object defaultValue = fieldSpec.getDefaultNullValue();
String stringDefaultValue = (String) defaultValue;
- int lengthOfLongestEntry = stringDefaultValue.length();
+ int lengthOfLongestEntry =
stringDefaultValue.getBytes(Charset.forName("UTF-8")).length;
Review comment:
Good catch
```suggestion
int lengthOfLongestEntry =
StringUtil.encodeUtf8(stringDefaultValue).length;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
