mayankshriv commented on a change in pull request #5339:
URL: https://github.com/apache/incubator-pinot/pull/5339#discussion_r421059479
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/plan/TransformPlanNode.java
##########
@@ -43,76 +39,70 @@
private final String _segmentName;
private final ProjectionPlanNode _projectionPlanNode;
- private final Set<String> _projectionColumns = new HashSet<>();
- private final Set<TransformExpressionTree> _expressions = new HashSet<>();
+ private final Set<TransformExpressionTree> _expressions;
private int _maxDocPerNextCall = DocIdSetPlanNode.MAX_DOC_PER_CALL;
- public TransformPlanNode(IndexSegment indexSegment, BrokerRequest
brokerRequest) {
+ public TransformPlanNode(IndexSegment indexSegment, BrokerRequest
brokerRequest,
+ Set<TransformExpressionTree> expressionsToPlan) {
Review comment:
`expressions` was too generic and being used in too many places for
different purposes, so I thought to call it `expressionsToPlan`.
Replied on `maxDocsPerBlock` above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
