This is an automated email from the ASF dual-hosted git repository.
mayanks pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 0e2ba53 Use ZkStarter.startLocaLZK() in PerfBenchmarkDriver. (#5380)
0e2ba53 is described below
commit 0e2ba53c7363b6bb062c4102e4d9b8f6bd3890f5
Author: Mayank Shrivastava <[email protected]>
AuthorDate: Wed May 13 13:27:08 2020 -0700
Use ZkStarter.startLocaLZK() in PerfBenchmarkDriver. (#5380)
It appears that the existing way to start ZK in PerfBenchmarkDriver can take
upto a miniute. Using ZKStart.startLocalZK() is much master.
---
.../main/java/org/apache/pinot/tools/perf/PerfBenchmarkDriver.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
a/pinot-tools/src/main/java/org/apache/pinot/tools/perf/PerfBenchmarkDriver.java
b/pinot-tools/src/main/java/org/apache/pinot/tools/perf/PerfBenchmarkDriver.java
index 50e2a90..cba0555 100644
---
a/pinot-tools/src/main/java/org/apache/pinot/tools/perf/PerfBenchmarkDriver.java
+++
b/pinot-tools/src/main/java/org/apache/pinot/tools/perf/PerfBenchmarkDriver.java
@@ -45,6 +45,7 @@ import org.apache.helix.manager.zk.ZKHelixAdmin;
import org.apache.helix.tools.ClusterVerifiers.StrictMatchExternalViewVerifier;
import org.apache.pinot.broker.broker.helix.HelixBrokerStarter;
import org.apache.pinot.common.utils.CommonConstants;
+import org.apache.pinot.common.utils.ZkStarter;
import org.apache.pinot.controller.ControllerConf;
import org.apache.pinot.controller.ControllerStarter;
import org.apache.pinot.controller.helix.core.PinotHelixResourceManager;
@@ -180,13 +181,12 @@ public class PerfBenchmarkDriver {
private void startZookeeper()
throws Exception {
- int zkPort = _conf.getZkPort();
if (!_conf.isStartZookeeper()) {
LOGGER.info("Skipping start zookeeper step. Assumes zookeeper is already
started.");
return;
}
- ZookeeperLauncher launcher = new ZookeeperLauncher(_tempDir);
- launcher.start(zkPort);
+ int zkPort = _conf.getZkPort();
+ ZkStarter.startLocalZkServer(zkPort);
}
private void startController() {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
