fx19880617 commented on a change in pull request #5419:
URL: https://github.com/apache/incubator-pinot/pull/5419#discussion_r428222776
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
##########
@@ -106,18 +108,26 @@ public DictionaryBasedGroupKeyGenerator(TransformOperator
transformOperator,
_isSingleValueColumn[i] =
transformOperator.getResultMetadata(groupByExpression).isSingleValue();
}
-
if (longOverflow) {
_globalGroupIdUpperBound = numGroupsLimit;
- _rawKeyHolder = new ArrayMapBasedHolder(_globalGroupIdUpperBound);
+ if
(!mapBasedRawKeyHolders.containsKey(ArrayMapBasedHolder.class.getName())) {
+ mapBasedRawKeyHolders.put(ArrayMapBasedHolder.class.getName(), new
ArrayMapBasedHolder(_globalGroupIdUpperBound).getInternal());
Review comment:
True. I feel we may need to have a range of groupIdBound, and only do
thread local for them. if it's too small or too large, maybe just create new
objects without and with initial size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
