vincentchenjl commented on a change in pull request #5435:
URL: https://github.com/apache/incubator-pinot/pull/5435#discussion_r430689663
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/task/TaskRunnerFactory.java
##########
@@ -59,16 +56,6 @@ public static TaskRunner getTaskRunnerFromTaskType(TaskType
taskType) {
case MONITOR:
taskRunner = new MonitorTaskRunner();
break;
- case DATA_COMPLETENESS:
Review comment:
Removed.
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/completeness/checker/Wo4WAvgDataCompletenessAlgorithm.java
##########
@@ -41,6 +41,7 @@
/**
* This is the implementation of the WO4W Average function or checking data
completeness of datasets
*/
+@Deprecated
public class Wo4WAvgDataCompletenessAlgorithm implements
DataCompletenessAlgorithm {
public static double DEFAULT_EXPECTED_COMPLETENESS = 80;
Review comment:
The issue is that `Wo4WAvgDataCompletenessAlgorithm` is used as default
value for `DatasetConfigBean.dataCompletenessAlgorithm`. I understand that it
is not used, but i am not sure about the impact if i remove this field from
`DatasetConfigBean` and still have this field inside the JSON in DB.
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/completeness/checker/DataCompletenessUtils.java
##########
@@ -261,13 +261,4 @@ public static DateTimeFormatter
getDateTimeFormatterForDataset(TimeSpec timeSpec
return bucketNameToCountStar;
}
- public static double getPercentCompleteness(PercentCompletenessFunctionInput
input) {
Review comment:
This class is used in `Wo4WAvgDataCompletenessAlgorithm`. We need to
drop both of them if we want to drop this. `Wo4WAvgDataCompletenessAlgorithm`
cannot be dropped due to the issue below.
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/completeness/checker/DataCompletenessUtils.java
##########
@@ -261,13 +261,4 @@ public static DateTimeFormatter
getDateTimeFormatterForDataset(TimeSpec timeSpec
return bucketNameToCountStar;
}
- public static double getPercentCompleteness(PercentCompletenessFunctionInput
input) {
Review comment:
I remove `Wo4WAvgDataCompletenessAlgorithm` completely and also the
field `DatasetConfigBean.dataCompletenessAlgorithm` from `DatasetConfigBean`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
