chenboat commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431604976
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/BlockSingleValIterator.java
##########
@@ -18,37 +18,17 @@
*/
package org.apache.pinot.core.common;
-/**
- *
- * TODO: Split into two classes, one for iterator over data, another over
dictionary id's.
- */
-public abstract class BlockSingleValIterator implements BlockValIterator {
-
- char nextCharVal() {
- throw new UnsupportedOperationException();
- }
+public interface BlockSingleValIterator extends BlockValIterator {
Review comment:
javadoc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
