siddharthteotia commented on pull request #5409: URL: https://github.com/apache/incubator-pinot/pull/5409#issuecomment-635647360
Address the review comments. Please take another look. This is standalone code at this point so want to get this in sooner and put up follow-ups in next couple of days. Here are the JMH results: `Benchmark Mode Cnt Score Units BenchmarkPinotDataBitSet.twoBitBulkWithGaps thrpt 3 28.537 ops/ms BenchmarkPinotDataBitSet.twoBitBulkWithGapsFast thrpt 3 44.332 ops/ms BenchmarkPinotDataBitSet.fourBitBulkWithGaps thrpt 3 28.262 ops/ms BenchmarkPinotDataBitSet.fourBitBulkWithGapsFast thrpt 3 42.449 ops/ms BenchmarkPinotDataBitSet.eightBitBulkWithGaps thrpt 3 26.816 ops/ms BenchmarkPinotDataBitSet.eightBitBulkWithGapsFast thrpt 3 38.777 ops/ms BenchmarkPinotDataBitSet.sixteenBitBulkWithGaps thrpt 3 21.095 ops/ms BenchmarkPinotDataBitSet.sixteenBitBulkWithGapsFast thrpt 3 38.380 ops/ms BenchmarkPinotDataBitSet.twoBitContiguous avgt 3 26.188 ms/op BenchmarkPinotDataBitSet.twoBitContiguousFast avgt 3 15.692 ms/op BenchmarkPinotDataBitSet.fourBitContiguous avgt 3 26.113 ms/op BenchmarkPinotDataBitSet.fourBitContiguousFast avgt 3 15.178 ms/op BenchmarkPinotDataBitSet.eightBitContiguous avgt 3 26.693 ms/op BenchmarkPinotDataBitSet.eightBitContiguousFast avgt 3 15.726 ms/op BenchmarkPinotDataBitSet.sixteenBitContiguous avgt 3 43.968 ms/op BenchmarkPinotDataBitSet.sixteenBitContiguousFast avgt 3 21.390 ms/op BenchmarkPinotDataBitSet.twoBitBulkContiguous avgt 3 32.504 ms/op BenchmarkPinotDataBitSet.twoBitBulkContiguousFast avgt 3 14.614 ms/op BenchmarkPinotDataBitSet.fourBitBulkContiguous avgt 3 30.794 ms/op BenchmarkPinotDataBitSet.fourBitBulkContiguousFast avgt 3 14.583 ms/op BenchmarkPinotDataBitSet.eightBitBulkContiguous avgt 3 16.525 ms/op BenchmarkPinotDataBitSet.eightBitBulkContiguousFast avgt 3 10.777 ms/op BenchmarkPinotDataBitSet.sixteenBitBulkContiguous avgt 3 54.731 ms/op BenchmarkPinotDataBitSet.sixteenBitBulkContiguousFast avgt 3 19.312 ms/op BenchmarkPinotDataBitSet.twoBitBulkContiguousUnaligned avgt 2 32.018 ms/op BenchmarkPinotDataBitSet.twoBitBulkContiguousUnalignedFast avgt 2 14.344 ms/op BenchmarkPinotDataBitSet.eightBitBulkContiguousUnaligned avgt 2 21.204 ms/op BenchmarkPinotDataBitSet.eightBitBulkContiguousUnalignedFast avgt 2 15.393 ms/op BenchmarkPinotDataBitSet.fourBitBulkContiguousUnaligned avgt 2 20.125 ms/op BenchmarkPinotDataBitSet.fourBitBulkContiguousUnalignedFast avgt 2 14.836 ms/op BenchmarkPinotDataBitSet.sixteenBitBulkContiguousUnaligned avgt 2 58.086 ms/op BenchmarkPinotDataBitSet.sixteenBitBulkContiguousUnalignedFast avgt 2 22.002 ms/op` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
