mcvsubbu commented on a change in pull request #5470:
URL: https://github.com/apache/incubator-pinot/pull/5470#discussion_r432905885
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -330,8 +330,32 @@ public long getLatestIngestionTimestamp() {
*/
private boolean isNoDictionaryColumn(Set<String> noDictionaryColumns,
Set<String> invertedIndexColumns,
Set<String> textIndexColumns, FieldSpec fieldSpec, String column) {
- return textIndexColumns.contains(column) ||
(noDictionaryColumns.contains(column) && fieldSpec.isSingleValueField()
- && !invertedIndexColumns.contains(column));
+ if (textIndexColumns.contains(column)) {
Review comment:
Excellent. I think we still rename the method as something along the
lines if `shouldCreateDictionaryForColumn()`, since it has some logic and is
not just checking the table config for noDictionary setting,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
