siddharthteotia commented on a change in pull request #5472:
URL: https://github.com/apache/incubator-pinot/pull/5472#discussion_r432982406
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -344,7 +346,7 @@ private boolean isNoDictionaryColumn(Set<String>
noDictionaryColumns, Set<String
// if the column is part of noDictionary set from table config
if (fieldSpec instanceof DimensionFieldSpec && _aggregateMetrics &&
(dataType == FieldSpec.DataType.STRING ||
dataType == FieldSpec.DataType.BYTES)) {
- _logger.info("Not creating dictionary in consuming segment for column
{} of type {}", column, dataType.toString());
+ _logger.info("Will create dictionary in consuming segment for column
{} of type {}", column, dataType.toString());
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
