chenboat commented on a change in pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r433647278
########## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/AndDocIdIterator.java ########## @@ -18,112 +18,52 @@ */ package org.apache.pinot.core.operator.dociditerators; -import java.util.Arrays; import org.apache.pinot.core.common.BlockDocIdIterator; import org.apache.pinot.core.common.Constants; -// TODO: Optimize this public final class AndDocIdIterator implements BlockDocIdIterator { Review comment: 1.javadoc? 2. comments about thread safety. is it safe/advisable to use this iterator in more than one thread? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org