yupeng9 commented on pull request #5487: URL: https://github.com/apache/incubator-pinot/pull/5487#issuecomment-639204731
Yup. I'll address this in another PR. > > @mayankshriv That's true for better code reuse. Though this PR is for a minor improvement, and I believe we could the refactoring in another PR. > > If you use PinotSegmentRecordReader, most of the code complexity you have in this PR will just go away, it will just become as simple as loop over records, and print values. I'll leave it up to you to decide. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
