This is an automated email from the ASF dual-hosted git repository.
mayanks pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new c152f18 Fix travis_quickstart.sh to handle delayed cluster setup.
(#5498)
c152f18 is described below
commit c152f18f273042668a6d91d5d15c7ca018f31b4a
Author: Mayank Shrivastava <[email protected]>
AuthorDate: Thu Jun 4 23:00:00 2020 -0700
Fix travis_quickstart.sh to handle delayed cluster setup. (#5498)
In case of delay in cluster setup, the script fails with syntax error
because the variable that stores the query result is either null or '',
which ends up being compared to a number.
The fix here is to add a check ensure that the query result is indeed
a number, before comparing it against a number. In case of delayed start,
the existing loop of trying 200 times (with a one second sleep) should
already suffice.
---
.travis/.travis_quickstart.sh | 28 +++++++++++++++++-----------
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/.travis/.travis_quickstart.sh b/.travis/.travis_quickstart.sh
index 40eae34..121eefa 100755
--- a/.travis/.travis_quickstart.sh
+++ b/.travis/.travis_quickstart.sh
@@ -41,9 +41,11 @@ sleep 30
for i in $(seq 1 200)
do
COUNT_STAR_RES=`curl -X POST --header 'Accept: application/json' -d
'{"sql":"select count(*) from baseballStats limit 1","trace":false}'
http://localhost:8000/query/sql | jq '.resultTable.rows[0][0]'`
- if [ "${COUNT_STAR_RES}" -eq 97889 ]; then
- PASS=1
- break
+ if [[ "${COUNT_STAR_RES}" =~ ^[0-9]+$ ]]; then
+ if [ "${COUNT_STAR_RES}" -eq 97889 ]; then
+ PASS=1
+ break
+ fi
fi
sleep 1
done
@@ -67,10 +69,12 @@ sleep 30
for i in $(seq 1 200)
do
COUNT_STAR_RES=`curl -X POST --header 'Accept: application/json' -d
'{"sql":"select count(*) from meetupRsvp limit 1","trace":false}'
http://localhost:8000/query/sql | jq '.resultTable.rows[0][0]'`
- if [ "${COUNT_STAR_RES}" -gt 0 ]; then
- if [ "${RES_1}" -eq 0 ]; then
- RES_1=${COUNT_STAR_RES}
- continue
+ if [[ "${COUNT_STAR_RES}" =~ ^[0-9]+$ ]]; then
+ if [ "${COUNT_STAR_RES}" -gt 0 ]; then
+ if [ "${RES_1}" -eq 0 ]; then
+ RES_1=${COUNT_STAR_RES}
+ continue
+ fi
fi
if [ "${COUNT_STAR_RES}" -gt "${RES_1}" ]; then
PASS=1
@@ -103,10 +107,12 @@ sleep 30
for i in $(seq 1 200)
do
COUNT_STAR_RES=`curl -X POST --header 'Accept: application/json' -d
'{"sql":"select count(*) from airlineStats limit 1","trace":false}'
http://localhost:8000/query/sql | jq '.resultTable.rows[0][0]'`
- if [ "${COUNT_STAR_RES}" -gt 0 ]; then
- if [ "${RES_1}" -eq 0 ]; then
- RES_1=${COUNT_STAR_RES}
- continue
+ if [[ "${COUNT_STAR_RES}" =~ ^[0-9]+$ ]]; then
+ if [ "${COUNT_STAR_RES}" -gt 0 ]; then
+ if [ "${RES_1}" -eq 0 ]; then
+ RES_1=${COUNT_STAR_RES}
+ continue
+ fi
fi
if [ "${COUNT_STAR_RES}" -gt "${RES_1}" ]; then
PASS=1
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
