npawar commented on a change in pull request #5430:
URL: https://github.com/apache/incubator-pinot/pull/5430#discussion_r437095719
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -466,19 +469,28 @@ private void processStreamEvents(MessageBatch
messagesAndOffsets, long idlePipeS
messagesAndOffsets.getMessageLengthAtIndex(index), reuse);
if (decodedRow != null) {
try {
- GenericRow transformedRow = _recordTransformer.transform(decodedRow);
-
- if (transformedRow != null) {
- realtimeRowsConsumedMeter = _serverMetrics
- .addMeteredTableValue(_metricKeyName,
ServerMeter.REALTIME_ROWS_CONSUMED, 1, realtimeRowsConsumedMeter);
- indexedMessageCount++;
+ List<GenericRow> transformedRows;
+ if
(decodedRow.getValue(CommonConstants.Segment.MULTIPLE_RECORDS_KEY) != null) {
+ transformedRows = new ArrayList<>();
+ for (Object singleRow : (Collection)
decodedRow.getValue(CommonConstants.Segment.MULTIPLE_RECORDS_KEY)) {
+ transformedRows.add(_recordTransformer.transform((GenericRow)
singleRow));
+ }
} else {
- realtimeRowsDroppedMeter = _serverMetrics
- .addMeteredTableValue(_metricKeyName,
ServerMeter.INVALID_REALTIME_ROWS_DROPPED, 1,
- realtimeRowsDroppedMeter);
+ transformedRows =
Collections.singletonList(_recordTransformer.transform(decodedRow));
}
- canTakeMore = _realtimeSegment.index(transformedRow, msgMetadata);
+ for (GenericRow transformedRow : transformedRows) {
+ if (transformedRow != null) {
Review comment:
that method would need to return indexedMessageCount, canTakeMore and 2
meters. Removed the list by immediately calling index and updating the
counters, in both cases. Created some code duplication, but i dont see a better
and simple way
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -466,19 +469,28 @@ private void processStreamEvents(MessageBatch
messagesAndOffsets, long idlePipeS
messagesAndOffsets.getMessageLengthAtIndex(index), reuse);
if (decodedRow != null) {
try {
- GenericRow transformedRow = _recordTransformer.transform(decodedRow);
-
- if (transformedRow != null) {
- realtimeRowsConsumedMeter = _serverMetrics
- .addMeteredTableValue(_metricKeyName,
ServerMeter.REALTIME_ROWS_CONSUMED, 1, realtimeRowsConsumedMeter);
- indexedMessageCount++;
+ List<GenericRow> transformedRows;
+ if
(decodedRow.getValue(CommonConstants.Segment.MULTIPLE_RECORDS_KEY) != null) {
+ transformedRows = new ArrayList<>();
+ for (Object singleRow : (Collection)
decodedRow.getValue(CommonConstants.Segment.MULTIPLE_RECORDS_KEY)) {
+ transformedRows.add(_recordTransformer.transform((GenericRow)
singleRow));
+ }
} else {
- realtimeRowsDroppedMeter = _serverMetrics
- .addMeteredTableValue(_metricKeyName,
ServerMeter.INVALID_REALTIME_ROWS_DROPPED, 1,
- realtimeRowsDroppedMeter);
+ transformedRows =
Collections.singletonList(_recordTransformer.transform(decodedRow));
Review comment:
avoided (at the cost of some code duplication in the if-else)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
